fix: support text selection under search highlights#20463
Conversation
|
/botio preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a81d0fc6ccd40ac/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b10e44dc6200d7d/output.txt |
|
(this PR should be labeled as |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b10e44dc6200d7d/output.txt Total script time: 0.99 mins Published |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a81d0fc6ccd40ac/output.txt Total script time: 3.51 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/09db56172e1d42e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.193.163.58:8877/68ec04988f22474/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/09db56172e1d42e/output.txt Total script time: 20.46 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/68ec04988f22474/output.txt Total script time: 40.20 mins
|
67487f1 to
5421859
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9fb19f94424d64c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9a278e12cdfa190/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9fb19f94424d64c/output.txt Total script time: 21.79 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9a278e12cdfa190/output.txt Total script time: 46.15 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/2e9c9e57d346c7a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2e9c9e57d346c7a/output.txt Total script time: 1.01 mins Published |
|
Looks good! Please squash the commits to have a single commit with a good commit message that explains the change (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits if you're not familiar with how to do that). We can merge this afterwards. Thanks! |
5421859 to
f01e4d4
Compare
Done - thanks! 🙏 |
|
It would be great if we could also fix #18190 (and https://bugzilla.mozilla.org/show_bug.cgi?id=1972953). |
|
Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20463 +/- ##
==========================================
- Coverage 59.78% 59.77% -0.02%
==========================================
Files 169 169
Lines 90165 90165
==========================================
- Hits 53907 53894 -13
- Misses 36258 36271 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes an issue where highlighted search results interfere with text selection. From what we can tell, the issue stems from moving
.endOfContentto the search highlight span, preventing the selection range from being extended.Steps to reproduce the issue:
pdfjs-highlight-issue.mov
The fix was tested on the demo viewer locally:
pdfjs-highlight-fix.mov