Encode FontPath data into an ArrayBuffer by ryzokuken · Pull Request #20346 · mozilla/pdf.js

ryzokuken · 2025-10-08T11:52:43Z

Serialize FontPath commands into a binary format
and store it in an ArrayBuffer so that it can
eventually be stored in a SharedArrayBuffer.

This PR is along the same lines as #20197 and #20340

calixteman · 2025-10-08T12:32:19Z

For the glyph paths, we should use the same format as "described" here:

pdf.js/src/display/canvas.js

Lines 1491 to 1520 in d83cbb2

    
           if (!(path instanceof Path2D)) { 
        
             // Using a SVG string is slightly slower than using the following loop. 
        
             const path2d = (data[0] = new Path2D()); 
        
             for (let i = 0, ii = path.length; i < ii; ) { 
        
               switch (path[i++]) { 
        
                 case DrawOPS.moveTo: 
        
                   path2d.moveTo(path[i++], path[i++]); 
        
                   break; 
        
                 case DrawOPS.lineTo: 
        
                   path2d.lineTo(path[i++], path[i++]); 
        
                   break; 
        
                 case DrawOPS.curveTo: 
        
                   path2d.bezierCurveTo( 
        
                     path[i++], 
        
                     path[i++], 
        
                     path[i++], 
        
                     path[i++], 
        
                     path[i++], 
        
                     path[i++] 
        
                   ); 
        
                   break; 
        
                 case DrawOPS.closePath: 
        
                   path2d.closePath(); 
        
                   break; 
        
                 default: 
        
                   warn(`Unrecognized drawing path operator: ${path[i - 1]}`); 
        
                   break; 
        
               } 
        
             } 
        
             path = path2d;

Using a SVG string is slightly slower and using this binary data would help to make the serialization a bit simpler.

test/unit/bin_font_path_info_spec.js

ryzokuken · 2025-10-14T13:54:27Z

Thanks for the comments, @calixteman @timvandermeij they should be addressed now PTAL.

src/shared/obj-bin-transform.js

test/unit/obj_bin_transform_spec.js

src/shared/obj-bin-transform.js

calixteman · 2025-12-03T15:28:13Z

/botio test

moz-tools-bot · 2025-12-03T15:28:16Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6e6abdba7b06450/output.txt

moz-tools-bot · 2025-12-03T15:28:16Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/53b9e899a12d47f/output.txt

moz-tools-bot · 2025-12-03T16:28:18Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/53b9e899a12d47f/output.txt

Total script time: 60.00 mins

moz-tools-bot · 2025-12-03T16:43:00Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6e6abdba7b06450/output.txt

Total script time: 74.72 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/6e6abdba7b06450/reftest-analyzer.html#web=eq.log

nicolo-ribaudo · 2025-12-04T17:55:13Z

/botio test

moz-tools-bot · 2025-12-04T17:55:16Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d057db0a22a3a8d/output.txt

moz-tools-bot · 2025-12-04T17:55:16Z

From: Bot.io (Windows)

Received

Command cmd_test from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.193.163.58:8877/be80322ea0a5bcf/output.txt

moz-tools-bot · 2025-12-04T18:55:17Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/d057db0a22a3a8d/output.txt

Total script time: 60.00 mins

moz-tools-bot · 2025-12-04T19:11:35Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/be80322ea0a5bcf/output.txt

Total script time: 76.31 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/be80322ea0a5bcf/reftest-analyzer.html#web=eq.log

Serialize FontPath commands into a binary format and store it in an ArrayBuffer so that it can eventually be stored in a SharedArrayBuffer.

nicolo-ribaudo · 2025-12-08T10:47:03Z

/botio test

moz-tools-bot · 2025-12-08T10:47:06Z

From: Bot.io (Windows)

Received

Command cmd_test from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4b27fb6097869d4/output.txt

moz-tools-bot · 2025-12-08T10:47:06Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7860f2a1e0b9aa0/output.txt

moz-tools-bot · 2025-12-08T11:27:40Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7860f2a1e0b9aa0/output.txt

Total script time: 40.56 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/7860f2a1e0b9aa0/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2025-12-08T12:04:16Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4b27fb6097869d4/output.txt

Total script time: 77.16 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/4b27fb6097869d4/reftest-analyzer.html#web=eq.log

ryzokuken requested a review from calixteman October 8, 2025 11:52

ryzokuken self-assigned this Oct 8, 2025

timvandermeij added the core label Oct 9, 2025

timvandermeij reviewed Oct 9, 2025

View reviewed changes

test/unit/bin_font_path_info_spec.js Outdated Show resolved Hide resolved

timvandermeij mentioned this pull request Oct 9, 2025

Serialize pattern data into ArrayBuffer #20340

Merged

ryzokuken force-pushed the binary-fontpath branch 2 times, most recently from 6d74dda to 9d2b39d Compare October 14, 2025 13:52

ryzokuken force-pushed the binary-fontpath branch from 9d2b39d to 089364a Compare October 29, 2025 09:45

Aditi-1400 force-pushed the binary-fontpath branch 2 times, most recently from 5991539 to 692031c Compare October 30, 2025 16:09

calixteman reviewed Nov 3, 2025

View reviewed changes

src/shared/obj-bin-transform.js Outdated Show resolved Hide resolved

calixteman reviewed Nov 3, 2025

View reviewed changes

test/unit/obj_bin_transform_spec.js Outdated Show resolved Hide resolved

Aditi-1400 force-pushed the binary-fontpath branch from 692031c to 1460415 Compare November 4, 2025 09:23

calixteman reviewed Nov 21, 2025

View reviewed changes

src/shared/obj-bin-transform.js Outdated Show resolved Hide resolved

calixteman reviewed Nov 21, 2025

View reviewed changes

src/shared/obj-bin-transform.js Outdated Show resolved Hide resolved

Aditi-1400 force-pushed the binary-fontpath branch from 1460415 to 4fed542 Compare November 28, 2025 19:53

Encode FontPath data into an ArrayBuffer

3a85770

Serialize FontPath commands into a binary format and store it in an ArrayBuffer so that it can eventually be stored in a SharedArrayBuffer.

Aditi-1400 force-pushed the binary-fontpath branch from 4fed542 to 3a85770 Compare December 8, 2025 10:44

calixteman merged commit f75812b into mozilla:master Dec 8, 2025
9 checks passed

calixteman mentioned this pull request Dec 21, 2025

[Bug]: Glyphs are not rendered correctly #20513

Closed

Conversation

ryzokuken commented Oct 8, 2025

Uh oh!

calixteman commented Oct 8, 2025

Uh oh!

Uh oh!

ryzokuken commented Oct 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixteman commented Dec 3, 2025

Uh oh!

moz-tools-bot commented Dec 3, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 3, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 3, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Dec 3, 2025

From: Bot.io (Windows)

Failed

Uh oh!

nicolo-ribaudo commented Dec 4, 2025

Uh oh!

moz-tools-bot commented Dec 4, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 4, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 4, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Dec 4, 2025

From: Bot.io (Windows)

Failed

Uh oh!

nicolo-ribaudo commented Dec 8, 2025

Uh oh!

moz-tools-bot commented Dec 8, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 8, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 8, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Dec 8, 2025

From: Bot.io (Windows)

Failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants