Skip to content

[Editor] Make sure the comment dialog always have relative coordinates between 0% and 100%#20328

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:fix_dialog_position
Oct 3, 2025
Merged

[Editor] Make sure the comment dialog always have relative coordinates between 0% and 100%#20328
calixteman merged 1 commit intomozilla:masterfrom
calixteman:fix_dialog_position

Conversation

@calixteman
Copy link
Contributor

This way, when the window is resized, the dialog stay visible.

…s between 0% and 100%

This way, when the window is resized, the dialog stay visible.
@calixteman calixteman added editor To Review For PRs to review after they've been merged (for example when reviewers are off). labels Oct 2, 2025
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e798d58fccf64e1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b1eebec2153d29e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/b1eebec2153d29e/output.txt

Total script time: 19.45 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/e798d58fccf64e1/output.txt

Total script time: 44.17 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit e1de28c into mozilla:master Oct 3, 2025
7 checks passed
@calixteman calixteman deleted the fix_dialog_position branch October 3, 2025 07:17
@timvandermeij timvandermeij removed their request for review October 4, 2025 12:27
@timvandermeij timvandermeij removed the To Review For PRs to review after they've been merged (for example when reviewers are off). label Oct 5, 2025
@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants