[Editor] Add a fake annotation (in the annotation layer) associated with an editor in order to be able to show the comment button (bug 1989420) by calixteman · Pull Request #20321 · mozilla/pdf.js

calixteman · 2025-09-30T17:37:16Z

No description provided.

calixteman · 2025-09-30T17:37:28Z

/botio integrationtest

moz-tools-bot · 2025-09-30T17:37:30Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/02c40552980fbe7/output.txt

moz-tools-bot · 2025-09-30T17:37:30Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6dae4e6a9a21485/output.txt

moz-tools-bot · 2025-09-30T17:56:52Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/02c40552980fbe7/output.txt

Total script time: 19.35 mins

Integration Tests: Passed

moz-tools-bot · 2025-09-30T18:19:49Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6dae4e6a9a21485/output.txt

Total script time: 42.30 mins

Integration Tests: FAILED

calixteman · 2025-09-30T18:43:18Z

/botio integrationtest

moz-tools-bot · 2025-09-30T18:43:21Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2e8c6ae13c0bc93/output.txt

moz-tools-bot · 2025-09-30T18:43:21Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/aba7f12fae42da1/output.txt

moz-tools-bot · 2025-09-30T19:02:52Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2e8c6ae13c0bc93/output.txt

Total script time: 19.50 mins

Integration Tests: Passed

moz-tools-bot · 2025-09-30T19:26:11Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/aba7f12fae42da1/output.txt

Total script time: 42.81 mins

Integration Tests: FAILED

calixteman · 2025-09-30T20:21:26Z

/botio integrationtest

moz-tools-bot · 2025-09-30T20:21:29Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/30c16c8c1e87e4e/output.txt

moz-tools-bot · 2025-09-30T20:21:29Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a5ccfe954131242/output.txt

moz-tools-bot · 2025-09-30T20:40:54Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/30c16c8c1e87e4e/output.txt

Total script time: 19.40 mins

Integration Tests: Passed

moz-tools-bot · 2025-09-30T21:05:35Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a5ccfe954131242/output.txt

Total script time: 44.08 mins

Integration Tests: FAILED

calixteman · 2025-10-01T07:03:12Z

/botio-windows integrationtest

moz-tools-bot · 2025-10-01T07:03:15Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4bf3f824a4541fa/output.txt

moz-tools-bot · 2025-10-01T07:06:30Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4bf3f824a4541fa/output.txt

Total script time: 3.24 mins

Integration Tests: FAILED

…ith an editor in order to be able to show the comment button (bug 1989420)

calixteman · 2025-10-01T07:09:20Z

/botio integrationtest

moz-tools-bot · 2025-10-01T07:09:23Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/75cc38ff20e93db/output.txt

moz-tools-bot · 2025-10-01T07:09:23Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a3d50b3292ee502/output.txt

moz-tools-bot · 2025-10-01T07:28:43Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a3d50b3292ee502/output.txt

Total script time: 19.31 mins

Integration Tests: Passed

moz-tools-bot · 2025-10-01T07:52:48Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/75cc38ff20e93db/output.txt

Total script time: 43.40 mins

Integration Tests: Passed

markmatney · 2025-10-02T18:11:04Z

This appears to have caused a regression; npx gulp makeref now hangs at the test for issue13915 and fails all subsequent tests. In the console output:

JavaScript error: http://127.0.0.1:12345/test/driver.js, line 295: Error: Rasterize.annotationLayer: "can't access property "getDestinationHash", this.linkService is null".

timvandermeij · 2025-10-05T11:19:56Z

src/display/annotation_layer.js

    return this.#editableAnnotations.get(id);
  }

+  addFakeAnnotation(editor) {


It would be good to have a docstring or other documentation that explains the purpose of the fake annotation (i.e., what do we need it for?).

timvandermeij · 2025-10-05T11:22:02Z

Looks good to me, with one comment.

calixteman requested a review from timvandermeij September 30, 2025 17:37

calixteman added editor To Review For PRs to review after they've been merged (for example when reviewers are off). labels Sep 30, 2025

calixteman force-pushed the bug1989420 branch from 81a3a91 to 518d6a4 Compare September 30, 2025 18:43

calixteman force-pushed the bug1989420 branch from 518d6a4 to 5774ee6 Compare September 30, 2025 20:21

calixteman force-pushed the bug1989420 branch from 5774ee6 to f57d3d6 Compare October 1, 2025 07:02

[Editor] Add a fake annotation (in the annotation layer) associated w…

12066af

…ith an editor in order to be able to show the comment button (bug 1989420)

calixteman force-pushed the bug1989420 branch from f57d3d6 to 12066af Compare October 1, 2025 07:09

calixteman merged commit d18289b into mozilla:master Oct 1, 2025
9 checks passed

calixteman deleted the bug1989420 branch October 1, 2025 11:40

timvandermeij removed their request for review October 4, 2025 12:27

timvandermeij reviewed Oct 5, 2025

View reviewed changes

timvandermeij removed the To Review For PRs to review after they've been merged (for example when reviewers are off). label Oct 5, 2025

Conversation

calixteman commented Sep 30, 2025

Uh oh!

calixteman commented Sep 30, 2025

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Sep 30, 2025

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Sep 30, 2025

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Sep 30, 2025

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Oct 1, 2025

Uh oh!

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Oct 1, 2025

Uh oh!

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Oct 1, 2025

From: Bot.io (Linux m4)

Success