Skip to content

[Annotation] In reading mode with new commment stuff enabled, use the comment popup for annotations without a popup but with some contents (bug 1991029)#20312

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:bug1991029
Sep 26, 2025
Merged

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Sep 26, 2025

No description provided.

@calixteman
[Annotation] In reading mode with new commment stuff enabled, use the…
7fc7b79 
… comment popup for annotations without a popup but with some contents (bug 1991029)
@calixteman calixteman added annotations editor To Review For PRs to review after they've been merged (for example when reviewers are off). labels Sep 26, 2025
@calixteman
Copy link
Contributor Author

calixteman commented Sep 26, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 26, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7f598634f952058/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 26, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/861899ef4f368ee/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 26, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7f598634f952058/output.txt

Total script time: 19.28 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 26, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/861899ef4f368ee/output.txt

Total script time: 44.00 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

calixteman commented Sep 26, 2025

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 26, 2025

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/93f421e2d244f90/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 26, 2025

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/131c12e7497c510/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 26, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/93f421e2d244f90/output.txt

Total script time: 19.55 mins

  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Sep 26, 2025

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/131c12e7497c510/output.txt

Total script time: 33.93 mins

  • Regression tests: Passed

@calixteman calixteman merged commit f64ece2 into mozilla:master Sep 26, 2025
9 checks passed
@calixteman calixteman deleted the bug1991029 branch September 26, 2025 18:26
@timvandermeij timvandermeij removed their request for review October 4, 2025 12:29
@timvandermeij timvandermeij removed the To Review For PRs to review after they've been merged (for example when reviewers are off). label Oct 5, 2025
@timvandermeij
Copy link
Contributor

timvandermeij commented Oct 5, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

annotations editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @moz-tools-bot @timvandermeij