[Editor] Add a new popup for comments (bug 1987425) by calixteman · Pull Request #20249 · mozilla/pdf.js

calixteman · 2025-09-08T16:34:48Z

And:

improve the editing dialog in removing menu;
position correctly the popup on the left/right depending on the direction value.

l10n/en-US/viewer.ftl

timvandermeij · 2025-09-11T19:27:37Z

/botio-linux preview

moz-tools-bot · 2025-09-11T19:27:40Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/a97af596674a6eb/output.txt

moz-tools-bot · 2025-09-11T19:33:45Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a97af596674a6eb/output.txt

Total script time: 0.97 mins

Published

Viewer: http://54.241.84.105:8877/a97af596674a6eb/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/a97af596674a6eb/legacy/web/viewer.html

timvandermeij · 2025-09-11T20:10:04Z

Initial finding: the edit/delete buttons inside the popup are quite hard to click. Steps to reproduce:

Open http://54.241.84.105:8877/a97af596674a6eb/web/viewer.html
Create a highlight with a comment.
Click the small inline comment button.
Hover over the edit and delete buttons. Even though the cursor is clearly over the button area, both buttons (but especially the edit button) are often not clickable:

Note that sometimes the background color does change and the button is clickable, but it requires being around the edges of the button.

calixteman · 2025-09-11T21:10:05Z

Note that sometimes the background color does change and the button is clickable, but it requires being around the edges of the button.

It's because the selected editor has higher z-index: I'll fix that.

timvandermeij · 2025-09-14T13:52:14Z

/botio-linux preview

moz-tools-bot · 2025-09-14T13:52:17Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6b10c22edf46c67/output.txt

moz-tools-bot · 2025-09-14T13:53:15Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/6b10c22edf46c67/output.txt

Total script time: 0.97 mins

Published

Viewer: http://54.241.84.105:8877/6b10c22edf46c67/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/6b10c22edf46c67/legacy/web/viewer.html

timvandermeij

Looks good to me, with the comments addressed.

src/display/editor/comment.js

src/display/editor/editor.js

web/comment_manager.js

l10n/en-US/viewer.ftl

calixteman · 2025-09-14T19:06:35Z

/botio integrationtest

moz-tools-bot · 2025-09-14T19:06:37Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fd6e78d95c21c2b/output.txt

moz-tools-bot · 2025-09-14T19:06:38Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/1dacbfc2d8e9ae6/output.txt

moz-tools-bot · 2025-09-14T19:25:27Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/fd6e78d95c21c2b/output.txt

Total script time: 18.82 mins

Integration Tests: FAILED

moz-tools-bot · 2025-09-14T20:28:17Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/1dacbfc2d8e9ae6/output.txt

Total script time: 40.11 mins

Integration Tests: FAILED

calixteman · 2025-09-14T20:50:52Z

/botio integrationtest

moz-tools-bot · 2025-09-14T20:50:55Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8b217e34c5fb607/output.txt

moz-tools-bot · 2025-09-14T20:50:56Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/5e7675450f8c142/output.txt

moz-tools-bot · 2025-09-14T21:09:09Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8b217e34c5fb607/output.txt

Total script time: 18.21 mins

Integration Tests: Passed

moz-tools-bot · 2025-09-14T21:40:47Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/5e7675450f8c142/output.txt

Total script time: 39.90 mins

Integration Tests: Passed

And: - improve the editing dialog in removing menu; - position correctly the popup on the left/right depending on the direction value.

calixteman requested a review from a team as a code owner September 8, 2025 16:34

flodolo requested changes Sep 8, 2025

View reviewed changes

l10n/en-US/viewer.ftl Outdated Show resolved Hide resolved

calixteman force-pushed the new_comment_popup_2 branch from 5693143 to dbbecc8 Compare September 8, 2025 18:19

flodolo approved these changes Sep 8, 2025

View reviewed changes

timvandermeij added the editor label Sep 8, 2025

calixteman force-pushed the new_comment_popup_2 branch 6 times, most recently from 3eced0a to 7a5c5f4 Compare September 10, 2025 16:25

timvandermeij self-requested a review September 11, 2025 19:23

calixteman force-pushed the new_comment_popup_2 branch 2 times, most recently from 3760865 to efd2197 Compare September 12, 2025 12:44

timvandermeij approved these changes Sep 14, 2025

View reviewed changes

calixteman force-pushed the new_comment_popup_2 branch from efd2197 to 1e7457f Compare September 14, 2025 19:06

calixteman force-pushed the new_comment_popup_2 branch from 1e7457f to 59e51c7 Compare September 14, 2025 20:50

[Editor] Add a new popup for comments (bug 1987425)

b660b72

And: - improve the editing dialog in removing menu; - position correctly the popup on the left/right depending on the direction value.

calixteman force-pushed the new_comment_popup_2 branch from 59e51c7 to b660b72 Compare September 15, 2025 06:24

calixteman merged commit 3432c19 into mozilla:master Sep 15, 2025
10 checks passed

calixteman deleted the new_comment_popup_2 branch September 15, 2025 06:27

Conversation

calixteman commented Sep 8, 2025

Uh oh!

Uh oh!

timvandermeij commented Sep 11, 2025

Uh oh!

moz-tools-bot commented Sep 11, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 11, 2025

From: Bot.io (Linux m4)

Success

Published

Uh oh!

timvandermeij commented Sep 11, 2025

Uh oh!

calixteman commented Sep 11, 2025

Uh oh!

timvandermeij commented Sep 14, 2025

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Linux m4)

Success

Published

Uh oh!

timvandermeij left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixteman commented Sep 14, 2025

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Sep 14, 2025

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Sep 14, 2025

From: Bot.io (Windows)

Success

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone