Skip to content

[Editor] When clicking on a comment in the sidebar, wait for the annotation editor layer to be rendered#20247

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:wait_for_rendered_editors
Sep 9, 2025
Merged

[Editor] When clicking on a comment in the sidebar, wait for the annotation editor layer to be rendered#20247
calixteman merged 1 commit intomozilla:masterfrom
calixteman:wait_for_rendered_editors

Conversation

@calixteman
Copy link
Contributor

and add a getter for the layer bounding rect.

…tation editor layer to be rendered

and add a getter for the layer bounding rect.
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing integration tests. Thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/4fb8b7f28d2f4d9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/546dd36c0283b61/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/4fb8b7f28d2f4d9/output.txt

Total script time: 18.11 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/546dd36c0283b61/output.txt

Total script time: 40.22 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 5b7f9ca into mozilla:master Sep 9, 2025
11 of 12 checks passed
@calixteman calixteman deleted the wait_for_rendered_editors branch September 9, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants