[Editor] Don't use a null signal for the comment button#20189
Merged
timvandermeij merged 1 commit intomozilla:masterfrom Aug 24, 2025
Merged
[Editor] Don't use a null signal for the comment button#20189timvandermeij merged 1 commit intomozilla:masterfrom
timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
Contributor
Author
|
For context, I found this error in the logs from one of the builds in #20029, namely https://github.com/mozilla/pdf.js/actions/runs/17189164618/job/48762368960?pr=20029. |
This removes the following error from the integration test logs: ``` JavaScript error: http://127.0.0.1:59283/build/generic/build/pdf.mjs, line 3879: TypeError: EventTarget.addEventListener: 'signal' member of AddEventListenerOptions is not an object. ``` Fixes 636ff50. Extends 6365188.
9f1eaa3 to
eec1bea
Compare
Contributor
Author
|
/botio integrationtest |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f35855b4893e888/output.txt |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/12086cbb293e023/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/12086cbb293e023/output.txt Total script time: 18.07 mins
|
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f35855b4893e888/output.txt Total script time: 38.85 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the following error from the integration test logs:
Fixes 636ff50.
Extends 6365188.