Improve the integration test code#20172
Conversation
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e4b49f80e27d9af/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/15189469c37f312/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/15189469c37f312/output.txt Total script time: 14.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e4b49f80e27d9af/output.txt Total script time: 31.38 mins
|
35aa389 to
04eb081
Compare
d5e59f0 to
b4367f0
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9d7197f7ba2fa30/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/eee4754c646368f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9d7197f7ba2fa30/output.txt Total script time: 18.54 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/eee4754c646368f/output.txt Total script time: 39.69 mins
|
8e988d3 to
6d482be
Compare
This test called `closeSinglePage` manually at the end of the test, which is inconsistent with all other tests that call `closePages` in an `afterEach` block. This commit fixes the difference for consistency.
…on test code The helper function was used in a number of places, but also a lot of places contained the annotation selector string inline. This commit makes sure that all places use `getAnnotationSelector` consistently to make sure the annotation selector string is only defined in a single place and to improve readability of the test code.
Most places have a newline before/after `before{Each,All}`,
`after{Each,All}` and `it` to visually separate the blocks for clarity,
but in a handful of places this wasn't done. This commit removes the
inconsistencies so that the test code is formatted consistently.
6d482be to
7f74fbf
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5207d5074caddeb/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/62cce018597539a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/62cce018597539a/output.txt Total script time: 18.37 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5207d5074caddeb/output.txt Total script time: 40.19 mins
|
The commit messages contain more information about the individual changes.