Skip to content

[Editor] Add the ability to get all the editable annotations in a pdf document#20167

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:get_all_editable_annotations
Aug 19, 2025
Merged

[Editor] Add the ability to get all the editable annotations in a pdf document#20167
calixteman merged 1 commit intomozilla:masterfrom
calixteman:get_all_editable_annotations

Conversation

@calixteman
Copy link
Contributor

We want to be able to show all the comments in a pdf even if the pages where they are haven't been rendered.
And it'll help to fix the issue #18915.

@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fc5151b7128e99a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1bf3989388db048/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/fc5151b7128e99a/output.txt

Total script time: 2.61 mins

  • Unit Tests: FAILED

@calixteman calixteman force-pushed the get_all_editable_annotations branch from 406cd62 to 77c9400 Compare August 14, 2025 15:56
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/1bf3989388db048/output.txt

Total script time: 6.43 mins

  • Unit Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f17af3ef8416cdc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dc2a3a84e1e5aaf/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/f17af3ef8416cdc/output.txt

Total script time: 2.42 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/dc2a3a84e1e5aaf/output.txt

Total script time: 7.34 mins

  • Unit Tests: Passed

@calixteman calixteman force-pushed the get_all_editable_annotations branch from 77c9400 to a3fb628 Compare August 14, 2025 21:07
@calixteman calixteman force-pushed the get_all_editable_annotations branch from a3fb628 to d4e49ab Compare August 18, 2025 15:46
… document

We want to be able to show all the comments in a pdf even if the pages where they are
haven't been rendered.
And it'll help to fix the issue mozilla#18915.
@calixteman calixteman force-pushed the get_all_editable_annotations branch from d4e49ab to 9e5ee1e Compare August 18, 2025 19:31
@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a65ba5970405994/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/514b2558db064c2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a65ba5970405994/output.txt

Total script time: 2.41 mins

  • Unit Tests: Passed

@calixteman
Copy link
Contributor Author

/botio-windows unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e02e7750693f017/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e02e7750693f017/output.txt

Total script time: 7.38 mins

  • Unit Tests: FAILED

@calixteman calixteman merged commit 65dd6b0 into mozilla:master Aug 19, 2025
9 checks passed
@calixteman calixteman deleted the get_all_editable_annotations branch August 19, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants