Skip to content

[Editor] Avoid to use a null signal when setting listeners in the editor toolbar#20166

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:fix_signal_integration_test
Aug 14, 2025
Merged

[Editor] Avoid to use a null signal when setting listeners in the editor toolbar#20166
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:fix_signal_integration_test

Conversation

@calixteman
Copy link
Contributor

It should fix the error:

JavaScript error: http://127.0.0.1:43303/build/generic/build/pdf.mjs, line 1445:
TypeError: EventTarget.addEventListener: 'signal' member of AddEventListenerOptions is not an object.

we've when running integration tests on the Linux bot.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b9b55226e4d13a4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2aae209bbe32b90/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/2aae209bbe32b90/output.txt

Total script time: 13.51 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/b9b55226e4d13a4/output.txt

Total script time: 31.33 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the fix_signal_integration_test branch from 50b6938 to 65dc388 Compare August 14, 2025 13:03
…tor toolbar

It should fix the error:
```
JavaScript error: http://127.0.0.1:43303/build/generic/build/pdf.mjs, line 1445:
TypeError: EventTarget.addEventListener: 'signal' member of AddEventListenerOptions is not an object.
```

we've when running integration tests on the Linux bot.
@calixteman calixteman force-pushed the fix_signal_integration_test branch from 65dc388 to 6365188 Compare August 14, 2025 13:07
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c71476a608f0958/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/402431837e7dd5e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/402431837e7dd5e/output.txt

Total script time: 13.61 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/c71476a608f0958/output.txt

Total script time: 28.87 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit 5951485 into mozilla:master Aug 14, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants