Add comment-* images when building components#20128
Merged
timvandermeij merged 1 commit intomozilla:masterfrom Jul 28, 2025
Merged
Add comment-* images when building components#20128timvandermeij merged 1 commit intomozilla:masterfrom
timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
Contributor
Author
|
@timvandermeij we should lint the built code before packaging in order to avoid such an issue. Wdyt ? |
timvandermeij
approved these changes
Jul 28, 2025
Contributor
|
Thank you for fixing this!
Yes, if there are ideas on how to do this please make a follow-up issue to do so. I'd be in favor of having some sort of linting or smoke testing to prevent this from happening again if that's possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes #20127.