Implement a delay for Chrome protocol calls in the integration tests, and skip the "must check that an existing highlight is ignored on hovering" integration test on Windows#20126
Conversation
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a9ee49e9c56d424/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c611a93e5b25fea/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c611a93e5b25fea/output.txt Total script time: 14.28 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a9ee49e9c56d424/output.txt Total script time: 32.22 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c4d8026d66433c5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8f63419cc49c9df/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c4d8026d66433c5/output.txt Total script time: 14.18 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8f63419cc49c9df/output.txt Total script time: 30.61 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c30de80f052b6bb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/904f424b1cc9af9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c30de80f052b6bb/output.txt Total script time: 14.19 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/904f424b1cc9af9/output.txt Total script time: 31.01 mins
|
31c585c to
397d4f2
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0593c1639d33b1a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d61aaed90ba47a3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d61aaed90ba47a3/output.txt Total script time: 14.27 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0593c1639d33b1a/output.txt Total script time: 29.92 mins
|
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f6647c21d09b575/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ee745205a2a2dcc/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ee745205a2a2dcc/output.txt Total script time: 14.24 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f6647c21d09b575/output.txt Total script time: 30.84 mins
|
|
/botio integrationtest |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2f965bd30948d77/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6c577ee4b20df34/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6c577ee4b20df34/output.txt Total script time: 14.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2f965bd30948d77/output.txt Total script time: 30.30 mins
|
7284628 to
cc443d8
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1d7b34ed0437bb6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0b19c9b6b99b511/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1d7b34ed0437bb6/output.txt Total script time: 14.23 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0b19c9b6b99b511/output.txt Total script time: 29.51 mins
|
cc443d8 to
74330aa
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4b1dd509506892d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/e5669fe409d5180/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4b1dd509506892d/output.txt Total script time: 30.56 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e5669fe409d5180/output.txt Total script time: 14.48 mins
|
In Chrome protocol calls are faster than in Firefox and thus trigger in quicker succession. This can cause intermittent failures because new protocol calls can run before events triggered by the previous protocol calls had a chance to be processed (essentially causing events to get lost). This commit fixes the issue by configuring Chrome with a protocol call delay value that gives it a more similar execution speed as Firefox (which also gives us more consistency between the two browser runs). Note that this doesn't negatively impact the overall runtime of the integration tests because Puppeteer already waits for a test to complete in both browsers before continuing to the next one and Chrome consistently was, and with this patch still slightly is, faster in completing the tests.
…g" integration test on Windows This is a temporary measure to reduce noise until mozilla#20136 is fixed. Note that this shouldn't be an issue in terms of coverage because we still run the test on Linux.
74330aa to
17dc9e9
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a84bdd2ff984324/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2b7341fba1fcddb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a84bdd2ff984324/output.txt Total script time: 14.46 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2b7341fba1fcddb/output.txt Total script time: 30.10 mins
|
The commit messages contain more information about the individual changes. The changes combined should fix the intermittent failures we experienced.