Fix intermittent failure in the viewer alert tests#20106
Merged
timvandermeij merged 1 commit intomozilla:masterfrom Jul 18, 2025
Merged
Fix intermittent failure in the viewer alert tests#20106timvandermeij merged 1 commit intomozilla:masterfrom
timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
It takes some time for the viewer alert to be updated after the editor is committed, but the current tests don't await that and proceed too fast to the viewer alert string assertion. This commit fixes the issue by waiting for the expected viewer alert string to appear instead.
Contributor
Author
|
/botio integrationtest |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/94f5867cb08f353/output.txt |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/337b41977bea3e2/output.txt |
timvandermeij
commented
Jul 18, 2025
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/337b41977bea3e2/output.txt Total script time: 13.67 mins
|
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/94f5867cb08f353/output.txt Total script time: 29.58 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It takes some time for the viewer alert to be updated after the editor is committed, but the current tests don't await that and proceed too fast to the viewer alert string assertion. This commit fixes the issue by waiting for the expected viewer alert string to appear instead.
Fixes #20105.