[Editor] Fix the highlighting colors in HCM (bug 1977259)#20099
[Editor] Fix the highlighting colors in HCM (bug 1977259)#20099timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/625a89e697c05b2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d6d06f5fd5b4940/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/625a89e697c05b2/output.txt Total script time: 13.18 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d6d06f5fd5b4940/output.txt Total script time: 28.96 mins
|
There was a problem hiding this comment.
Mostly looks good, but the HCM color mapping feels a bit hard to follow. Maybe it can be simplified a bit if we simply have two mappings of "color name -> color" for HCM and non-HCM, and have one lookup function that checks the right one depending on the HCM state?
Using the same color in HCM or non-HCM was inducing a too small contrast between some bg/fg colors making the text a bit hard to read.
|
r=me, with passing integration tests. The current version looks better to me; thanks! |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/546dfc9cdecbc2c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fa5b517cb2263a2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/fa5b517cb2263a2/output.txt Total script time: 14.69 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/546dfc9cdecbc2c/output.txt Total script time: 30.18 mins
|
Using the same color in HCM or non-HCM was inducing a too small contrast between some bg/fg colors making the text a bit hard to read.