Make horizontal padding relative to device width#20093
Make horizontal padding relative to device width#20093calixteman merged 1 commit intomozilla:masterfrom
Conversation
e6b1855 to
34b9d1b
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4375380d5de4019/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0e0e163fb47af3b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0e0e163fb47af3b/output.txt Total script time: 13.43 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4375380d5de4019/output.txt Total script time: 28.72 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6ad6660848e57f3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6ad6660848e57f3/output.txt Total script time: 0.96 mins Published |
34b9d1b to
dc6a573
Compare
The fixed -400px horizontal offset used by scrollIntoView led to horizontal scroll only moving part-way right on narrow screens. The highlights near the right-edge remained party or completely off screen. This centres the highlighted match on any viewport width while clamping the left margin to 20-400px. On very narrow screens the scrollbar now moves all the way to the right instead of stopping midway.
dc6a573 to
9babc14
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/d68c28b809a9d13/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/906e67a82fe8b3a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d68c28b809a9d13/output.txt Total script time: 13.28 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/906e67a82fe8b3a/output.txt Total script time: 33.14 mins
|
The fixed -400px horizontal offset used by
scrollIntoView led to horizontal scroll only moving part-way right on narrow screens. The highlights near the right-edge remained party or completely off screen.
This centres the highlighted match on any viewport width while clamping the left margin to 20-400px. On very narrow screens the scrollbar now moves all the way to the right instead of stopping midway.
This change was previously added in #20047 and it was reverted because it caused the regression: #20075
This fixes the regression and also the horizontal scroll.
The test added to check for #20075 only checks for pinch zoom in Chrome since Firefox doesn't support Touch on non-touch devices, so we are just testing it on chrome for now.
I am open to ideas on better ways of testing this. :)