Skip to content

Use the canvas context from mozPrintCallback when printing a pdf from the Firefox viewer#20082

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:fix_firefox_printing
Jul 11, 2025
Merged

Use the canvas context from mozPrintCallback when printing a pdf from the Firefox viewer#20082
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:fix_firefox_printing

Conversation

@calixteman
Copy link
Contributor

The context is specific to the callback and cannot be created from the canvas itself.

… the Firefox viewer

The context is specific to the callback and cannot be created from the canvas itself.
Copy link
Collaborator

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@calixteman
Copy link
Contributor Author

@timvandermeij I made a try on TC with this patch and the CI is green (especially the Android test which was failing).

@timvandermeij timvandermeij merged commit 094253f into mozilla:master Jul 11, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants