Skip to content

[Editor] Add the possibility to add Popup annotations (bug 1976724)#20080

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:add_comment_1
Jul 17, 2025
Merged

[Editor] Add the possibility to add Popup annotations (bug 1976724)#20080
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:add_comment_1

Conversation

@calixteman
Copy link
Contributor

It's a first big step.
This patch contains a new modal dialog to let the user edit/update a Popup

@calixteman calixteman requested a review from timvandermeij July 10, 2025 17:28
@calixteman calixteman requested a review from a team as a code owner July 10, 2025 17:28
@calixteman
Copy link
Contributor Author

For now, there are no tests: they'll come later once the feature is almost ready (some changes are expected in the UI).

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d6e43d40aede482/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/d6e43d40aede482/output.txt

Total script time: 0.19 mins

@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1326990a61859be/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/1326990a61859be/output.txt

Total script time: 1.04 mins

Published

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but I'd like to have one final look after the comments have been addressed to make sure I didn't miss anything.

It's a first big step.
This patch contains a new modal dialog to let the user edit/update a Popup
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the final comment addressed. Looks good!

@timvandermeij timvandermeij merged commit 23bd705 into mozilla:master Jul 17, 2025
10 checks passed
@calixteman calixteman deleted the add_comment_1 branch July 17, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants