Skip to content

[Editor] Add a color picker in the toolbar of Ink and Freetext annotations#20070

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:editor_toolbar_color
Jul 14, 2025
Merged

[Editor] Add a color picker in the toolbar of Ink and Freetext annotations#20070
calixteman merged 1 commit intomozilla:masterfrom
calixteman:editor_toolbar_color

Conversation

@calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/01816abba62ab60/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/01816abba62ab60/output.txt

Total script time: 0.95 mins

Published

@calixteman calixteman force-pushed the editor_toolbar_color branch 3 times, most recently from ab5c1e7 to 5a03f26 Compare July 9, 2025 15:12
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6e495e613178db4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9bd421a16698c80/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/9bd421a16698c80/output.txt

Total script time: 13.36 mins

  • Integration Tests: FAILED

@calixteman calixteman marked this pull request as ready for review July 9, 2025 15:29
@calixteman calixteman requested a review from a team as a code owner July 9, 2025 15:29
@calixteman calixteman requested review from timvandermeij and removed request for a team July 9, 2025 15:29
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/6e495e613178db4/output.txt

Total script time: 27.15 mins

  • Integration Tests: FAILED

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, with some questions answered that I'm unsure about before I approve this.

@calixteman calixteman force-pushed the editor_toolbar_color branch from 5a03f26 to e397d34 Compare July 13, 2025 18:41
@calixteman calixteman requested a review from timvandermeij July 13, 2025 18:41
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed. Thanks!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/304e3036ab65b61/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3dce2979888f453/output.txt

@calixteman calixteman force-pushed the editor_toolbar_color branch from e397d34 to dbd6f8c Compare July 14, 2025 21:00
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/96eb321ef754c56/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f24ca8d66cdc930/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/304e3036ab65b61/output.txt

Total script time: 13.11 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/96eb321ef754c56/output.txt

Total script time: 13.29 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/3dce2979888f453/output.txt

Total script time: 28.52 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/f24ca8d66cdc930/output.txt

Total script time: 27.82 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 4f2390a into mozilla:master Jul 14, 2025
10 checks passed
@calixteman calixteman deleted the editor_toolbar_color branch July 14, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants