Remove the shadow from the links (bug 1974436)#20041
Remove the shadow from the links (bug 1974436)#20041calixteman merged 1 commit intomozilla:masterfrom
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/afa89af558242d2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/afa89af558242d2/output.txt Total script time: 0.91 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/37c2b4653db8923/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d7027456e94f423/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/37c2b4653db8923/output.txt Total script time: 0.70 mins
Image differences available at: http://54.241.84.105:8877/37c2b4653db8923/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d7027456e94f423/output.txt Total script time: 2.36 mins
Image differences available at: http://54.193.163.58:8877/d7027456e94f423/reftest-analyzer.html#web=eq.log |
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with the comment addressed and passing tests. Looks good!
The shadow was taken into account when computing the bounding box of the section containing the link and it was making the clip path wrong. Since the shadow is almost invisible because of the opacity, the yellow color and the clip we can remove it without causing any visual regressions (and as a side effect it'll avoid to use resources to compute it when displayed).
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b56a563a298721d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0e3bfc41e6e58fe/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b56a563a298721d/output.txt Total script time: 29.86 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0e3bfc41e6e58fe/output.txt Total script time: 57.53 mins
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6860a8b5d529332/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3a6061a4716c7b1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3a6061a4716c7b1/output.txt Total script time: 16.12 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/6860a8b5d529332/output.txt Total script time: 25.57 mins
|
The shadow was taken into account when computing the bounding box of the section containing the link and it was making the clip path wrong. Since the shadow is almost invisible because of the opacity, the yellow color and the clip we can remove it without causing any visual regressions (and as a side effect it'll avoid to use resources to compute it when displayed).