Fix intermittent failure in the find integration tests#20000
Merged
timvandermeij merged 1 commit intomozilla:masterfrom Jun 8, 2025
Merged
Fix intermittent failure in the find integration tests#20000timvandermeij merged 1 commit intomozilla:masterfrom
timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
After clicking the find button we need to wait for the input field to appear before we try to type in it, but instead we were waiting for the button to appear. However, the button is always present, so the current `waitForSelector` call is basically a no-op, and this can cause the integration tests to fail intermittently if we continue before the input field is actually visible. This appears to be due a typo first introduced in commit d10da90 that has been copy/pasted. This commit fixes the issue by waiting for the input field to be visible before we continue typing in it.
45c17f1 to
64a2d70
Compare
Contributor
Author
|
/botio integrationtest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/600601779fed42c/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f4e36d35d325a6c/output.txt |
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/600601779fed42c/output.txt Total script time: 13.61 mins
|
Contributor
Author
|
/botio-linux integrationtest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After clicking the find button we need to wait for the input field to appear before we try to type in it, but instead we were waiting for the button to appear. However, the button is always present, so the current
waitForSelectorcall is basically a no-op, and this can cause the integration tests to fail intermittently if we continue before the input field is actually visible.This appears to be due a typo first introduced in commit d10da90 that has been copy/pasted.
This commit fixes the issue by waiting for the input field to be visible before we continue typing in it.
Fixes #19999.