[Editor] Add the possibility to add a popup to an annotation when saving by calixteman · Pull Request #19976 · mozilla/pdf.js

calixteman · 2025-05-27T16:10:21Z

When saving/printing, only update the properties which are provided and set a default value only when there is no pre-existing one.

calixteman · 2025-05-27T16:10:32Z

/botio test

moz-tools-bot · 2025-05-27T16:10:35Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b92710557233f58/output.txt

moz-tools-bot · 2025-05-27T16:10:35Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bd65ce2204ba4f0/output.txt

moz-tools-bot · 2025-05-27T16:40:20Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/bd65ce2204ba4f0/output.txt

Total script time: 29.74 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: Passed

moz-tools-bot · 2025-05-27T17:07:37Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b92710557233f58/output.txt

Total script time: 57.03 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: Passed

src/core/annotation.js

src/core/primitives.js

src/core/annotation.js

calixteman · 2025-05-28T17:44:41Z

/botio test

moz-tools-bot · 2025-05-28T17:44:44Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a484cd16b662951/output.txt

moz-tools-bot · 2025-05-28T17:44:44Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b21f12f94b94489/output.txt

moz-tools-bot · 2025-05-28T18:15:01Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b21f12f94b94489/output.txt

Total script time: 30.28 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: Passed

moz-tools-bot · 2025-05-28T18:41:40Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a484cd16b662951/output.txt

Total script time: 56.93 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: Passed

src/core/core_utils.js

src/core/primitives.js

test/unit/annotation_spec.js

src/shared/util.js

timvandermeij · 2025-07-08T17:26:04Z

I'll have another look at this once #20064 is merged and this PR is rebased.

timvandermeij

r=me, with the comments addressed. Thank you!

src/core/annotation.js

When saving/printing, only update the properties which are provided and set a default value only when there is no pre-existing one.

calixteman · 2025-07-11T19:47:53Z

/botio test

moz-tools-bot · 2025-07-11T19:47:57Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/d2db69fc584f6af/output.txt

moz-tools-bot · 2025-07-11T19:47:57Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/924a039f6e40d03/output.txt

moz-tools-bot · 2025-07-11T20:19:36Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/924a039f6e40d03/output.txt

Total script time: 31.63 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: Passed

moz-tools-bot · 2025-07-11T20:57:35Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d2db69fc584f6af/output.txt

Total script time: 55.27 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: Passed

timvandermeij · 2025-07-12T13:29:02Z

/botio makeref

moz-tools-bot · 2025-07-12T13:29:05Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/30cba2ecbe704c6/output.txt

moz-tools-bot · 2025-07-12T13:29:05Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d6f5390da3f5c1c/output.txt

moz-tools-bot · 2025-07-12T13:45:06Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d6f5390da3f5c1c/output.txt

Total script time: 16.00 mins

Make references: Passed
Check references: Passed

moz-tools-bot · 2025-07-12T13:54:15Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/30cba2ecbe704c6/output.txt

Total script time: 25.16 mins

Make references: Passed
Check references: Passed

calixteman added the editor label May 27, 2025

calixteman requested a review from Snuffleupagus May 27, 2025 16:42

Snuffleupagus reviewed May 28, 2025

View reviewed changes

src/core/annotation.js Outdated Show resolved Hide resolved

src/core/primitives.js Outdated Show resolved Hide resolved

src/core/annotation.js Outdated Show resolved Hide resolved

Snuffleupagus added the annotations label May 28, 2025

calixteman force-pushed the write_popup branch from e348849 to 52ff5cd Compare May 28, 2025 16:22

calixteman requested a review from Snuffleupagus May 29, 2025 14:24

calixteman force-pushed the write_popup branch from 52ff5cd to e1d4530 Compare June 4, 2025 14:36

calixteman requested review from timvandermeij and removed request for Snuffleupagus June 30, 2025 16:18

timvandermeij requested changes Jul 6, 2025

View reviewed changes

src/core/core_utils.js Outdated Show resolved Hide resolved

src/core/primitives.js Show resolved Hide resolved

src/core/primitives.js Show resolved Hide resolved

test/unit/annotation_spec.js Show resolved Hide resolved

src/shared/util.js Show resolved Hide resolved

calixteman force-pushed the write_popup branch from e1d4530 to 6bb1387 Compare July 9, 2025 07:46

timvandermeij self-requested a review July 11, 2025 18:27

timvandermeij approved these changes Jul 11, 2025

View reviewed changes

src/core/annotation.js Outdated Show resolved Hide resolved

src/core/annotation.js Outdated Show resolved Hide resolved

[Editor] Add the possibility to add a popup to an annotation when saving

8fc51dc

When saving/printing, only update the properties which are provided and set a default value only when there is no pre-existing one.

calixteman force-pushed the write_popup branch from 6bb1387 to 8fc51dc Compare July 11, 2025 19:42

timvandermeij approved these changes Jul 11, 2025

View reviewed changes

timvandermeij merged commit b7a0f01 into mozilla:master Jul 12, 2025
9 checks passed

Conversation

calixteman commented May 27, 2025

Uh oh!

calixteman commented May 27, 2025

Uh oh!

moz-tools-bot commented May 27, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented May 27, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented May 27, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented May 27, 2025

From: Bot.io (Windows)

Failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixteman commented May 28, 2025

Uh oh!

moz-tools-bot commented May 28, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented May 28, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented May 28, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented May 28, 2025

From: Bot.io (Windows)

Failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timvandermeij commented Jul 8, 2025

Uh oh!

timvandermeij left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

calixteman commented Jul 11, 2025

Uh oh!

moz-tools-bot commented Jul 11, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Jul 11, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Jul 11, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Jul 11, 2025

From: Bot.io (Windows)

Failed

Uh oh!

Uh oh!

timvandermeij commented Jul 12, 2025

Uh oh!

moz-tools-bot commented Jul 12, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Jul 12, 2025