Skip to content

Replace semi-private fields/methods with actual private ones in src/core/catalog.js#19964

Merged
timvandermeij merged 2 commits intomozilla:masterfrom
Snuffleupagus:core-catalog-private
May 24, 2025
Merged

Replace semi-private fields/methods with actual private ones in src/core/catalog.js#19964
timvandermeij merged 2 commits intomozilla:masterfrom
Snuffleupagus:core-catalog-private

Conversation

@Snuffleupagus
Copy link
Collaborator

Additionally, move a couple of "public" fields out of the class constructor and initialize them directly instead.

…core/catalog.js`

Additionally, move a couple of "public" fields out of the class constructor and initialize them directly instead.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dd00aa2d90f68c2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/03680eb23687b1f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/03680eb23687b1f/output.txt

Total script time: 29.76 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/dd00aa2d90f68c2/output.txt

Total script time: 56.92 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9a773b9f74f03e8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/9a773b9f74f03e8/output.txt

Total script time: 2.39 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c409aafa1d62f5c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/c409aafa1d62f5c/output.txt

Total script time: 15.96 mins

  • Regression tests: Passed

@timvandermeij timvandermeij merged commit d90ec29 into mozilla:master May 24, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the core-catalog-private branch January 25, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants