Move a few helper functions/classes out of the src/display/api.js file#19962
Merged
timvandermeij merged 2 commits intomozilla:masterfrom May 24, 2025
Merged
Move a few helper functions/classes out of the src/display/api.js file#19962timvandermeij merged 2 commits intomozilla:masterfrom
src/display/api.js file#19962timvandermeij merged 2 commits intomozilla:masterfrom
Conversation
Given that this file represents the official API, it's difficult to avoid it becoming fairly large as we add new functionality. However, it also contains a couple of smaller (and internal) helpers that we can move into a new utils-file. Also, we inline the `DEFAULT_RANGE_CHUNK_SIZE` constant since it's only used *once* and its value has never been changed in over a decade.
This isn't directly part of the official API, and having this class in its own file could help avoid future changes (e.g. issue 18148) affecting the size of the `src/display/api.js` file unnecessarily.
Collaborator
Author
|
/botio test |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/867e4c74ba4ff70/output.txt |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/55391e084b715b6/output.txt |
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/55391e084b715b6/output.txt Total script time: 29.71 mins
|
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/867e4c74ba4ff70/output.txt Total script time: 56.17 mins
|
timvandermeij
approved these changes
May 24, 2025
Contributor
|
Good idea; thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move a few helper functions/classes out of the
src/display/api.jsfileGiven that this file represents the official API, it's difficult to avoid it becoming fairly large as we add new functionality. However, it also contains a couple of smaller (and internal) helpers that we can move into a new utils-file.
Also, we inline the
DEFAULT_RANGE_CHUNK_SIZEconstant since it's only used once and its value has never been changed in over a decade.Move the
PDFObjectsclass to its own fileThis isn't directly part of the official API, and having this class in its own file could help avoid future changes (e.g. issue 18148) affecting the size of the
src/display/api.jsfile unnecessarily.