[api-minor] Create the css color to use with the canvas in the worker#19953
[api-minor] Create the css color to use with the canvas in the worker#19953calixteman merged 1 commit intomozilla:masterfrom
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/43010c9ed1873cc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/36f7b9d6a69d83a/output.txt |
6c7e573 to
4906daa
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/36f7b9d6a69d83a/output.txt Total script time: 30.57 mins
Image differences available at: http://54.241.84.105:8877/36f7b9d6a69d83a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/43010c9ed1873cc/output.txt Total script time: 58.22 mins
Image differences available at: http://54.193.163.58:8877/43010c9ed1873cc/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f2671812be702e9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2841ba7635d6fed/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f2671812be702e9/output.txt Total script time: 29.80 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2841ba7635d6fed/output.txt Total script time: 58.64 mins
|
Snuffleupagus
left a comment
There was a problem hiding this comment.
It slightly reduces the time spent to draw and the memory used.
How much of an improvement are we talking about? Any benchmarking results from relevant PDF documents?
r=me, thank you.
With the pdf: Here are two profiles:
Without the patch we spend around 8ms to just create the css color in the main thread which isn't crazy for sure.
Since we don't create anymore the temporary arrays, we win in term of memory (~400K) which leads to win some time when GCing and when cloning the data to be sent to the main thread. I've another patch to remove the subarrays on the qcms' side which should help to improve the performance of |
It slightly reduces the time spent to draw and the memory used.
4906daa to
5789afd
Compare
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6da619b11cb68e7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6da619b11cb68e7/output.txt Total script time: 30.13 mins
|
It slightly reduces the time spent to draw and the memory used.