Unify method return values in the ObjectLoader class, and simplify how the ObjectLoader is used#19895
Merged
Snuffleupagus merged 2 commits intomozilla:masterfrom May 6, 2025
Merged
Conversation
Given that all the methods are already asynchronous we can just use `await` more throughout this code, rather than having to explicitly return function-calls and `undefined`. Note also how none of the `ObjectLoader.prototype.load` call-sites use the return value.
The `ObjectLoader.prototype.load` method has a fast-path, which avoids any lookup/parsing if the entire PDF document is already loaded. However, we still need to create an `ObjectLoader`-instance which seems unnecessary in that case. Hence we introduce a *static* `ObjectLoader.load` method, which will help avoid creating `ObjectLoader`-instances needlessly and also (slightly) shortens the call-sites. To ensure that the new method will be used, we extend the `no-restricted-syntax` ESLint rule to "forbid" direct usage of `new ObjectLoader()`.
Collaborator
Author
|
/botio test |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c79511bcd031d90/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/93452580a8aa58d/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c79511bcd031d90/output.txt Total script time: 29.77 mins
|
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/93452580a8aa58d/output.txt Total script time: 61.78 mins
|
ObjectLoader class, Simplify how the ObjectLoader is usedObjectLoader class, and simplify how the ObjectLoader is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify method return values in the
ObjectLoaderclassGiven that all the methods are already asynchronous we can just use
awaitmore throughout this code, rather than having to explicitly return function-calls andundefined.Note also how none of the
ObjectLoader.prototype.loadcall-sites use the return value.Simplify how the
ObjectLoaderis usedThe
ObjectLoader.prototype.loadmethod has a fast-path, which avoids any lookup/parsing if the entire PDF document is already loaded.However, we still need to create an
ObjectLoader-instance which seems unnecessary in that case.Hence we introduce a static
ObjectLoader.loadmethod, which will help avoid creatingObjectLoader-instances needlessly and also (slightly) shortens the call-sites.To ensure that the new method will be used, we extend the
no-restricted-syntaxESLint rule to "forbid" direct usage ofnew ObjectLoader().