Simplify the loadXfaImages method and related code#19885
Merged
timvandermeij merged 1 commit intomozilla:masterfrom May 4, 2025
Merged
Simplify the loadXfaImages method and related code#19885timvandermeij merged 1 commit intomozilla:masterfrom
loadXfaImages method and related code#19885timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
Currently we create an intermediate `Dict` during parsing, however that seems unnecessary since (note especially the second point): - The `NameOrNumberTree.prototype.getAll` method will already resolve any references, as needed, during parsing. - The `Catalog.prototype.xfaImages` getter is invoked, via the `BasePdfManager`-instance, such that any `MissingDataException`s are already handled correctly.
Collaborator
Author
|
/botio xfatest |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/59c66ae7d8d3873/output.txt |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9b72fd4c345a696/output.txt |
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9b72fd4c345a696/output.txt Total script time: 17.30 mins
|
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/59c66ae7d8d3873/output.txt Total script time: 40.01 mins
|
timvandermeij
approved these changes
May 4, 2025
Contributor
|
Thank you for simplifying this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we create an intermediate
Dictduring parsing, however that seems unnecessary since (note especially the second point):NameOrNumberTree.prototype.getAllmethod will already resolve any references, as needed, during parsing.Catalog.prototype.xfaImagesgetter is invoked, via theBasePdfManager-instance, such that anyMissingDataExceptions are already handled correctly.