Skip to content

Add useractivation check for response function#19855

Merged
calixteman merged 1 commit intomozilla:masterfrom
1Jesper1:hotfix/useractivation-response
Apr 28, 2025
Merged

Add useractivation check for response function#19855
calixteman merged 1 commit intomozilla:masterfrom
1Jesper1:hotfix/useractivation-response

Conversation

@1Jesper1
Copy link
Contributor

@1Jesper1 1Jesper1 commented Apr 23, 2025

Add useractivation check for response function.
#19851

@calixteman
Copy link
Contributor

calixteman commented Apr 23, 2025

Linting isn't ok.
@1Jesper1, you can run it locally in using npx gulp lint (you can add --fix to auto-fix when it's possible)

@1Jesper1
Copy link
Contributor Author

1Jesper1 commented Apr 23, 2025

@calixteman Seems the error was: 621:5 error Method 'response' expected no return value consistent-return
I now return null.

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Apr 24, 2025

Please see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits

@1Jesper1 1Jesper1 force-pushed the hotfix/useractivation-response branch from 1ac0ed6 to 8af06a4 Compare April 24, 2025 20:40
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Apr 26, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Apr 26, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/975780488001339/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Apr 26, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e1b5218a4384b38/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Apr 26, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/975780488001339/output.txt

Total script time: 13.04 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Apr 26, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e1b5218a4384b38/output.txt

Total script time: 31.49 mins

  • Integration Tests: FAILED

calixteman
calixteman approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit 2e10ff6 into mozilla:master Apr 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

form-js

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@1Jesper1 @calixteman @Snuffleupagus @moz-tools-bot