[api-minor] Remove the CMapCompressionType enumeration#18951
Merged
timvandermeij merged 2 commits intomozilla:masterfrom Oct 27, 2024
Merged
[api-minor] Remove the CMapCompressionType enumeration#18951timvandermeij merged 2 commits intomozilla:masterfrom
CMapCompressionType enumeration#18951timvandermeij merged 2 commits intomozilla:masterfrom
Conversation
Given that we've not shipped, nor used, anything except binary CMaps for years let's just cache them unconditionally (since that's a tiny bit less code).
After the binary CMap format had been added there were also some ideas about *maybe* providing other formats, see [here](mozilla#8064 (comment)), however that was over seven years ago and we still only use binary CMaps. Hence it now seems reasonable to simplify the relevant code by removing `CMapCompressionType` and instead just use a boolean to indicate the type of the built-in CMaps.
5369829 to
b048420
Compare
Collaborator
Author
|
/botio test |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c730453cc33efa2/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6f6a6f8eaaa92bd/output.txt |
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c730453cc33efa2/output.txt Total script time: 32.04 mins
Image differences available at: http://54.241.84.105:8877/c730453cc33efa2/reftest-analyzer.html#web=eq.log |
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6f6a6f8eaaa92bd/output.txt Total script time: 51.39 mins
Image differences available at: http://54.193.163.58:8877/6f6a6f8eaaa92bd/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Oct 27, 2024
Contributor
|
Thank you for simplifying this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unconditionally cache built-in CMaps on the worker-thread
Given that we've not shipped, nor used, anything except binary CMaps for years let's just cache them unconditionally (since that's a tiny bit less code).
[api-minor] Remove the
CMapCompressionTypeenumerationAfter the binary CMap format had been added there were also some ideas about maybe providing other formats, see here, however that was over seven years ago and we still only use binary CMaps.
Hence it now seems reasonable to simplify the relevant code by removing
CMapCompressionTypeand instead just use a boolean to indicate the type of the built-in CMaps.