Fix failing integration test on Windows with Chrome by calixteman · Pull Request #18860 · mozilla/pdf.js

calixteman · 2024-10-06T14:29:06Z

It fixes #18775.

calixteman · 2024-10-06T14:29:17Z

/botio integrationtest

moz-tools-bot · 2024-10-06T14:29:20Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00b997dc5c2d57e/output.txt

moz-tools-bot · 2024-10-06T14:29:21Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cdbd7908806881b/output.txt

moz-tools-bot · 2024-10-06T14:39:09Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/00b997dc5c2d57e/output.txt

Total script time: 9.80 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T14:48:57Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/cdbd7908806881b/output.txt

Total script time: 19.60 mins

Integration Tests: FAILED

calixteman · 2024-10-06T14:57:27Z

/botio integrationtest

moz-tools-bot · 2024-10-06T14:57:29Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ec07e899a32bca4/output.txt

moz-tools-bot · 2024-10-06T14:57:29Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5ed9c8e29197288/output.txt

moz-tools-bot · 2024-10-06T15:07:11Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/ec07e899a32bca4/output.txt

Total script time: 9.68 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T15:17:23Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5ed9c8e29197288/output.txt

Total script time: 19.89 mins

Integration Tests: FAILED

calixteman · 2024-10-06T15:25:57Z

/botio integrationtest

moz-tools-bot · 2024-10-06T15:25:59Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3158c6694f86b07/output.txt

moz-tools-bot · 2024-10-06T15:25:59Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/76636f2dc0bf9d6/output.txt

moz-tools-bot · 2024-10-06T15:35:40Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/76636f2dc0bf9d6/output.txt

Total script time: 9.68 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T15:46:06Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3158c6694f86b07/output.txt

Total script time: 20.11 mins

Integration Tests: FAILED

calixteman · 2024-10-06T16:01:10Z

/botio-windows integrationtest

moz-tools-bot · 2024-10-06T16:01:13Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b2c2aa87f913827/output.txt

moz-tools-bot · 2024-10-06T16:05:00Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/b2c2aa87f913827/output.txt

Total script time: 3.77 mins

Integration Tests: Passed

calixteman · 2024-10-06T16:08:35Z

/botio-windows integrationtest

moz-tools-bot · 2024-10-06T16:08:37Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/db45f8c6591100e/output.txt

moz-tools-bot · 2024-10-06T16:29:26Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/db45f8c6591100e/output.txt

Total script time: 20.81 mins

Integration Tests: FAILED

calixteman · 2024-10-06T16:54:02Z

/botio integrationtest

moz-tools-bot · 2024-10-06T16:54:05Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1c357fb457d8fb2/output.txt

moz-tools-bot · 2024-10-06T16:54:05Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/91d5aa039bf288d/output.txt

calixteman · 2024-10-06T19:13:38Z

@timvandermeij The issue is fixed now: the root cause was about not having integer coordinates. I don't know if some was selected but for sure the selectionchange event wasn't triggered because of that.
So thank you for the tip (about rounding the coordinates) 😃

timvandermeij

I'm happy that we have a solution in the works for this test now. Mostly looks good to me, with a few questions and s/Windws/Windows in the commit message.

test/integration/highlight_editor_spec.mjs

calixteman · 2024-10-06T20:22:41Z

/botio integrationtest

moz-tools-bot · 2024-10-06T20:22:44Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/78239c26e58b0f3/output.txt

moz-tools-bot · 2024-10-06T20:22:44Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fa6441345a50bbe/output.txt

moz-tools-bot · 2024-10-06T20:32:28Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/fa6441345a50bbe/output.txt

Total script time: 9.72 mins

Integration Tests: FAILED

moz-tools-bot · 2024-10-06T20:42:43Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/78239c26e58b0f3/output.txt

Total script time: 19.96 mins

Integration Tests: FAILED

calixteman · 2024-10-06T20:47:59Z

/botio integrationtest

moz-tools-bot · 2024-10-06T20:48:01Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/72207c8f55103c7/output.txt

moz-tools-bot · 2024-10-06T20:48:01Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/394c96f2c8d83ab/output.txt

moz-tools-bot · 2024-10-06T20:57:43Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/72207c8f55103c7/output.txt

Total script time: 9.69 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T21:07:40Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/394c96f2c8d83ab/output.txt

Total script time: 19.64 mins

Integration Tests: Passed

timvandermeij

r=me, with the comments below addressed. Thank you for doing this!

test/integration/highlight_editor_spec.mjs

test/integration/text_layer_spec.mjs

calixteman · 2024-10-10T19:26:00Z

/botio integrationtest

moz-tools-bot · 2024-10-10T19:26:02Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/367a53ef4948d0a/output.txt

moz-tools-bot · 2024-10-10T19:26:03Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/931f430823ab37c/output.txt

It fixes mozilla#18775.

moz-tools-bot · 2024-10-10T19:35:07Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/931f430823ab37c/output.txt

Total script time: 9.07 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-10T19:45:42Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/367a53ef4948d0a/output.txt

Total script time: 19.65 mins

Integration Tests: Passed

calixteman force-pushed the issue18775 branch from 1db75ca to d6fee54 Compare October 6, 2024 14:56

calixteman force-pushed the issue18775 branch from d6fee54 to ebdebe7 Compare October 6, 2024 15:25

calixteman force-pushed the issue18775 branch from ebdebe7 to dd752ff Compare October 6, 2024 16:00

calixteman force-pushed the issue18775 branch from dd752ff to 07594b0 Compare October 6, 2024 16:08

timvandermeij added the test label Oct 6, 2024

calixteman force-pushed the issue18775 branch from 07594b0 to 4c2a96e Compare October 6, 2024 16:53

calixteman requested a review from timvandermeij October 6, 2024 19:14

timvandermeij reviewed Oct 6, 2024

View reviewed changes

test/integration/highlight_editor_spec.mjs Show resolved Hide resolved

test/integration/highlight_editor_spec.mjs Show resolved Hide resolved

timvandermeij mentioned this pull request Oct 6, 2024

Fix typing logic in the scripting integration tests #18862

Merged

calixteman force-pushed the issue18775 branch from 4ec0e9b to 2d9bfd1 Compare October 6, 2024 20:21

calixteman force-pushed the issue18775 branch from 2d9bfd1 to 15c930d Compare October 6, 2024 20:45

timvandermeij approved these changes Oct 8, 2024

View reviewed changes

test/integration/highlight_editor_spec.mjs Show resolved Hide resolved

test/integration/highlight_editor_spec.mjs Outdated Show resolved Hide resolved

test/integration/text_layer_spec.mjs Outdated Show resolved Hide resolved

Snuffleupagus changed the title ~~Fix failing integration test on Windws with Chrome~~ Fix failing integration test on Windows with Chrome Oct 10, 2024

calixteman force-pushed the issue18775 branch from 15c930d to 31c7bbf Compare October 10, 2024 19:25

Fix failing integration test on Windows with Chrome

edc2cd1

It fixes mozilla#18775.

calixteman force-pushed the issue18775 branch from 31c7bbf to edc2cd1 Compare October 10, 2024 19:28

calixteman merged commit c6d01ca into mozilla:master Oct 10, 2024

calixteman deleted the issue18775 branch October 10, 2024 19:46

timvandermeij mentioned this pull request Oct 11, 2024

Fix the intermittent integration test failure when an highlight is hovered #18721

Closed

timvandermeij mentioned this pull request Jul 29, 2025

[Bug]: Integration test "must check that an existing highlight is ignored on hovering" permafails on Windows #20136

Open

Conversation

calixteman commented Oct 6, 2024

Uh oh!

calixteman commented Oct 6, 2024

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Oct 6, 2024

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Oct 6, 2024

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Oct 6, 2024

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Success

Uh oh!

calixteman commented Oct 6, 2024

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Oct 6, 2024

Uh oh!

moz-tools-bot commented Oct 6, 2024

calixteman commented Oct 6, 2024 •

edited

Loading

timvandermeij left a comment •

edited

Loading