Skip to content

[Editor] Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024)#18573

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:cancel_ai_requests
Aug 7, 2024
Merged

[Editor] Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024)#18573
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:cancel_ai_requests

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

The user can change a setting in a tab and it must have an effect in the current viewer.

@calixteman

Copy link
Copy Markdown
Contributor Author

It can be tested in Firefox and I'll add a test here before the end of the week.

Comment thread src/display/editor/stamp.js
Comment thread web/app.js Outdated
Comment thread web/new_alt_text_manager.js Outdated
Comment thread web/new_alt_text_manager.js Outdated
Comment thread web/new_alt_text_manager.js Outdated
@Snuffleupagus

Copy link
Copy Markdown
Collaborator

It doesn't appear that an updated patch was pushed, so I don't know what to re-review here :-)

…bleGuessAltText to the viewer (bug 1912024)

The user can change a setting in a tab and it must have an effect in the current viewer.

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments fixed; thank you!

Comment thread web/firefoxcom.js
Comment thread web/new_alt_text_manager.js
Comment thread web/new_alt_text_manager.js
Comment thread web/firefoxcom.js
Comment thread web/firefoxcom.js
@calixteman calixteman merged commit fef2853 into mozilla:master Aug 7, 2024
@calixteman calixteman deleted the cancel_ai_requests branch August 7, 2024 21:11
@calixteman

Copy link
Copy Markdown
Contributor Author

I forgot to push my last changes....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants