Update the current stride before composing when decoding a text region by calixteman · Pull Request #17875 · mozilla/pdf.js

calixteman · 2024-04-03T09:26:46Z

We do something similar to:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/pdfium/core/fxcodec/jbig2/JBig2_TrdProc.cpp;l=373-379;drc=24c6be6924df3ff585bb63f6aed4e2c81e791fb2

calixteman · 2024-04-03T09:26:54Z

/botio test

moz-tools-bot · 2024-04-03T09:26:57Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00b8a5e9cca4525/output.txt

moz-tools-bot · 2024-04-03T09:26:57Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e70ebaed9e8c00a/output.txt

moz-tools-bot · 2024-04-03T09:53:22Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/00b8a5e9cca4525/output.txt

Total script time: 26.40 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 44
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/00b8a5e9cca4525/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-04-03T10:10:20Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e70ebaed9e8c00a/output.txt

Total script time: 43.37 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 15

Image differences available at: http://54.193.163.58:8877/e70ebaed9e8c00a/reftest-analyzer.html#web=eq.log

calixteman · 2024-04-03T12:04:26Z

/botio test

moz-tools-bot · 2024-04-03T12:04:29Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4ad686e91d117c0/output.txt

moz-tools-bot · 2024-04-03T12:04:29Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6ab30cb5e8918a2/output.txt

src/core/jbig2.js

moz-tools-bot · 2024-04-03T12:30:50Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/4ad686e91d117c0/output.txt

Total script time: 26.35 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 19
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/4ad686e91d117c0/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-04-03T12:49:48Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6ab30cb5e8918a2/output.txt

Total script time: 45.30 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/6ab30cb5e8918a2/reftest-analyzer.html#web=eq.log

Fixes mozilla#17871. We do something similar to: https://source.chromium.org/chromium/chromium/src/+/main:third_party/pdfium/core/fxcodec/jbig2/JBig2_TrdProc.cpp;l=373-379;drc=24c6be6924df3ff585bb63f6aed4e2c81e791fb2

calixteman · 2024-04-03T16:45:31Z

/botio test

moz-tools-bot · 2024-04-03T16:45:34Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/30068395913f99b/output.txt

moz-tools-bot · 2024-04-03T16:45:35Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b8fcd4735a9f193/output.txt

moz-tools-bot · 2024-04-03T17:12:12Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/30068395913f99b/output.txt

Total script time: 26.61 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 15
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/30068395913f99b/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-04-03T17:31:35Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b8fcd4735a9f193/output.txt

Total script time: 45.99 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/b8fcd4735a9f193/reftest-analyzer.html#web=eq.log

calixteman · 2024-04-03T18:41:34Z

/botio makeref

moz-tools-bot · 2024-04-03T18:41:36Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/893e2c316334448/output.txt

moz-tools-bot · 2024-04-03T18:41:36Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1f3c3cb28412513/output.txt

moz-tools-bot · 2024-04-03T19:00:34Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/893e2c316334448/output.txt

Total script time: 18.95 mins

Lint: Passed
Make references: Passed
Check references: Passed

moz-tools-bot · 2024-04-03T19:08:59Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1f3c3cb28412513/output.txt

Total script time: 27.37 mins

Lint: Passed
Make references: Passed
Check references: Passed

timvandermeij added the image-jbig2 label Apr 3, 2024

calixteman force-pushed the jbig2_issue branch from b40c9dc to 18b284c Compare April 3, 2024 12:03

github-advanced-security bot found potential problems Apr 3, 2024

View reviewed changes

src/core/jbig2.js Fixed Show fixed Hide fixed

calixteman force-pushed the jbig2_issue branch from 18b284c to 56088bd Compare April 3, 2024 14:14

calixteman marked this pull request as ready for review April 3, 2024 14:14

calixteman requested a review from Snuffleupagus April 3, 2024 14:14

Snuffleupagus approved these changes Apr 3, 2024

View reviewed changes

Snuffleupagus added the image-conversion label Apr 3, 2024

calixteman force-pushed the jbig2_issue branch from 56088bd to 3f2f983 Compare April 3, 2024 16:45

calixteman merged commit 25f6a0c into mozilla:master Apr 3, 2024

Conversation

calixteman commented Apr 3, 2024

Uh oh!

calixteman commented Apr 3, 2024

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Apr 3, 2024

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Windows)

Received

Uh oh!

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Apr 3, 2024

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Apr 3, 2024

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Apr 3, 2024

From: Bot.io (Windows)

Success

Uh oh!

Reviewers

Assignees

Labels

Projects