Skip to content

[Annotation] Don't rotate an annotation when it has the NoRotate flag#16110

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:norotate
Mar 6, 2023
Merged

[Annotation] Don't rotate an annotation when it has the NoRotate flag#16110
calixteman merged 1 commit intomozilla:masterfrom
calixteman:norotate

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Mar 5, 2023

No description provided.

@calixteman calixteman requested a review from Snuffleupagus March 5, 2023 12:57
@calixteman calixteman linked an issue Mar 5, 2023 that may be closed by this pull request
comments on PDF files in landscape orientation are rotated and in wrong position #7631
Closed
Snuffleupagus
Snuffleupagus previously approved these changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with comments addressed and all tests passing (or improving); thank you!

@calixteman
Copy link
Contributor Author

calixteman commented Mar 5, 2023

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/313308bcad033a8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9070d4b6fa0b24a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/313308bcad033a8/output.txt

Total script time: 26.07 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 27

Image differences available at: http://54.241.84.105:8877/313308bcad033a8/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/9070d4b6fa0b24a/output.txt

Total script time: 32.97 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 41

Image differences available at: http://54.193.163.58:8877/9070d4b6fa0b24a/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus dismissed their stale review March 5, 2023 15:04

Regression in annotation-fileattachment-page1

@calixteman calixteman force-pushed the norotate branch 2 times, most recently from 3f1cca7 to 82022cb Compare March 5, 2023 16:41
@calixteman
Copy link
Contributor Author

calixteman commented Mar 5, 2023

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8c35bd6b341cdac/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2076382ad0368bb/output.txt

Snuffleupagus
Snuffleupagus reviewed Mar 5, 2023
View reviewed changes
@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2076382ad0368bb/output.txt

Total script time: 26.84 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 22
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2076382ad0368bb/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8c35bd6b341cdac/output.txt

Total script time: 34.25 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 31

Image differences available at: http://54.193.163.58:8877/8c35bd6b341cdac/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

calixteman commented Mar 5, 2023

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b9b22fbda5267f0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2b26be9dc237c51/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2b26be9dc237c51/output.txt

Total script time: 27.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 27
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2b26be9dc237c51/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b9b22fbda5267f0/output.txt

Total script time: 33.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 32

Image differences available at: http://54.193.163.58:8877/b9b22fbda5267f0/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus reviewed Mar 5, 2023
View reviewed changes
@calixteman
Copy link
Contributor Author

calixteman commented Mar 5, 2023

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b8a95bc8d6b460f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3a7c881abdb678d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b8a95bc8d6b460f/output.txt

Total script time: 26.99 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 31
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/b8a95bc8d6b460f/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2023

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3a7c881abdb678d/output.txt

Total script time: 33.18 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 40
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/3a7c881abdb678d/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

calixteman commented Mar 6, 2023

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2023

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e0a306b08770873/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2023

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2667e9da0aaf12c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2023

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2667e9da0aaf12c/output.txt

Total script time: 27.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 29
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2667e9da0aaf12c/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2023

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e0a306b08770873/output.txt

Total script time: 33.68 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 35

Image differences available at: http://54.193.163.58:8877/e0a306b08770873/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit e11371c into mozilla:master Mar 6, 2023
@calixteman
Copy link
Contributor Author

calixteman commented Mar 6, 2023

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2023

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/a5a5cb6ac6a4838/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2023

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/24ae47d7306d678/output.txt

@mozilla mozilla deleted a comment from pdfjsbot Mar 6, 2023
@mozilla mozilla deleted a comment from pdfjsbot Mar 6, 2023
@mozilla mozilla deleted a comment from pdfjsbot Mar 6, 2023
@mozilla mozilla deleted a comment from pdfjsbot Mar 6, 2023
@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2023

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a5a5cb6ac6a4838/output.txt

Total script time: 22.59 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2023

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/24ae47d7306d678/output.txt

Total script time: 24.40 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman mentioned this pull request Jun 15, 2023
Closed
@yyliu12 yyliu12 mentioned this pull request Jun 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees

No one assigned

Labels

annotations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

comments on PDF files in landscape orientation are rotated and in wrong position

3 participants

@calixteman @pdfjsbot @Snuffleupagus