fix text layer transform when font-size less than the browser's min font-size#14427
Closed
helianthuswhite wants to merge 1 commit intomozilla:masterfrom
Closed
fix text layer transform when font-size less than the browser's min font-size#14427helianthuswhite wants to merge 1 commit intomozilla:masterfrom
helianthuswhite wants to merge 1 commit intomozilla:masterfrom
Conversation
Snuffleupagus
requested changes
Jan 7, 2022
Collaborator
There was a problem hiding this comment.
As mentioned in #14426 (comment), this feels a little "heavy" as far as implementations go.
Also, when manually testing this code it doesn't seem to work as expected in Firefox (which is the primary development target) since 1 is always returned regardless of the browser setting.
Collaborator
|
Looking at this again, the following issues are present:
All-in-all, this patch unfortunately seems a bit too far from correct/working; hence let's close this PR and keep the issue open to track the problem. |
Author
|
OK, thank you. I will have a think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14426