Skip to content

Fallback to font name matching, when checking for serif fonts (issue 13845)#14064

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
Snuffleupagus:issue-13845
Sep 25, 2021
Merged

Fallback to font name matching, when checking for serif fonts (issue 13845)#14064
timvandermeij merged 1 commit intomozilla:masterfrom
Snuffleupagus:issue-13845

Conversation

@Snuffleupagus
Copy link
Collaborator

In order to handle fonts that specify completely bogus /Flags-entries, fallback to font name matching to determine if the font is a serif one.

Fixes #13845

@timvandermeij
Copy link
Contributor

/botio test

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux browsertest

1 similar comment
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux browsertest

@mozilla mozilla deleted a comment from pdfjsbot Sep 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Sep 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Sep 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Sep 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Sep 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Sep 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Sep 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Sep 22, 2021
…13845)

In order to handle fonts that specify completely bogus /Flags-entries, fallback to font name matching to determine if the font is a serif one.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/61ef19591de5a75/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7a40bab78ff5c73/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/61ef19591de5a75/output.txt

Total script time: 22.59 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 13

Image differences available at: http://54.241.84.105:8877/61ef19591de5a75/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/7a40bab78ff5c73/output.txt

Total script time: 42.28 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/7a40bab78ff5c73/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f9430c7f23f09ea/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/f9430c7f23f09ea/output.txt

Total script time: 4.23 mins

Published

@timvandermeij timvandermeij merged commit cc110b8 into mozilla:master Sep 25, 2021
@timvandermeij
Copy link
Contributor

Looks good to me; thanks!

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/34002e42863dece/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 2

Live output at: http://54.193.163.58:8877/e84dadc5d4ce8dd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/34002e42863dece/output.txt

Total script time: 18.14 mins

  • Lint: Passed
  • Make references: FAILED

@timvandermeij
Copy link
Contributor

/botio-linux makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00bb75639ccfb60/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/00bb75639ccfb60/output.txt

Total script time: 17.96 mins

  • Lint: Passed
  • Make references: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b1230dfcaf8d5b2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/e84dadc5d4ce8dd/output.txt

Total script time: 37.15 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/b1230dfcaf8d5b2/output.txt

Total script time: 18.30 mins

  • Lint: Passed
  • Make references: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/94a71606ff854d1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/94a71606ff854d1/output.txt

Total script time: 19.82 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some letters in textLayer aren't properly aligned with the rendered text

3 participants