Skip to content

[Bug]: Signature editor doorhanger renders incorrectly #20091

@timvandermeij

Description

@timvandermeij

Attach (recommended) or Link to PDF file

Any PDF file from the local disk

Web browser and its version

Firefox 140.0.4

Operating system and its version

Arch Linux

PDF.js version

5.2.183 (embedded version in Firefox 140.0.4 as logged by the web console) and the current master build

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

  1. Drag a local PDF file into the Firefox tab bar or open the PDF file with Firefox otherwise.
  2. Click the signature editor button.
  3. Notice that there is no icon before the text (I would have expected a plus icon like for stamp annotations):
Image
  1. Notice that for the Dutch locale specifically the text length exceeds the maximum size of the doorhanger, causing an overflow and a scrollbar on hoovering:
Image

What is the expected behavior?

The add button contains a plus icon and the doorhanger resizes based on the text context (which differs per locale).

What went wrong?

The add button doesn't contain an icon and overflows for locales with long texts.

Link to a viewer

No response

Additional context

This can also be reproduced with the current master build:

  1. Go to https://mozilla.github.io/pdf.js/web/viewer.html.
  2. Run PDFViewerApplication.preferences.set('enableSignatureEditor', true) in the web console and refresh the page.
  3. Open any PDF file and follow the same steps as above.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions