icons: Honor context-fill / context-fill-opacity, and dark mode as a fallback in page action icon#2835
Merged
bakulf merged 1 commit intomozilla:mainfrom Dec 12, 2025
Merged
Conversation
…fallback in page action icon The only reason this icon doesn't look terrible in dark mode is because there's a hack in Firefox that we want to remove, see bug 2001318.
1 task
bakulf
approved these changes
Dec 12, 2025
Member
|
For visibility, this patch followed from a report at https://bugzilla.mozilla.org/show_bug.cgi?id=2001318 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only reason this icon doesn't look terrible in dark mode is because there's a hack in Firefox that we want to remove, see bug 2001318.
Before submitting your pull request
npm testand all tests passed.Description
The only reason this icon doesn't look terrible in dark mode is because there's a hack in Firefox that we want to remove, see bug 2001318.
This shouldn't make the behavior worse with and without the hack, and allows us to remove it.
Type of change
Select all that apply.