This repository was archived by the owner on Sep 13, 2023. It is now read-only.
Fix support for larger than 2 GB databases on Windows#24
Closed
repi wants to merge 6 commits intomozilla:masterfrom
Closed
Fix support for larger than 2 GB databases on Windows#24repi wants to merge 6 commits intomozilla:masterfrom
repi wants to merge 6 commits intomozilla:masterfrom
Conversation
This will fail on older versions of LMDB on Windows that doesn't have the ITS#3824 fix
This includes important improvements such as ITS#8324 which enables sparse file allocation on Windows
This was discussed and allegedly fixed in LMDB in January 2016 by defining _FILE_OFFSET_BITS but that doesn't work because Windows headers do not support that POSIX define. In this fix I re-define `off_t` in build.rs to int64 instead. Original discussion and non-working fix: https://www.openldap.org/lists/openldap-bugs/201605/msg00015.htm LMDB/lmdb@20dec1f Should be fixed properly in upstream LMDB though, this is a workaround until then.
mykmelez
reviewed
Jan 7, 2019
| // | ||
| // was discussed here and allgedly fixed in January 2016 but fix doesn't work as | ||
| // Windows doesn't support _FILE_OFFSET_BITS | ||
| // https://www.openldap.org/lists/openldap-bugs/201605/msg00015.htm |
There was a problem hiding this comment.
This URL returns a 404 NOT FOUND error. It looks like the correct URL is https://www.openldap.org/lists/openldap-bugs/201605/msg00015.html (with the trailing "l"; perhaps due to a recent reconfiguration of the server?).
I'm ok with taking a fix like this downstream, however I agree that it should ultimately be fixed upstream. Are you planning to submit a fix or comment in https://www.openldap.org/its/index.cgi/Incoming?id=8420 about the persistence of the bug despite the original fix for it? |
26 tasks
|
Closing due to inactivity, please reopen if there's updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed and allegedly fixed in LMDB in January 2016 by defining
_FILE_OFFSET_BITSbut that doesn't work because Windows headers do not support that POSIX define (link).In this fix I re-define
off_tin build.rs toint64instead.Original discussion and non-working fix:
https://www.openldap.org/lists/openldap-bugs/201605/msg00015.htm
LMDB/lmdb@20dec1f
Should be fixed properly in upstream LMDB though, this is a workaround until then.
This PR is based on #23 which uses the latest LMDB version.