This repository was archived by the owner on Aug 26, 2022. It is now read-only.
bug 1399639: Make requirements more complex, upgrade django-tidings #4660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a section explaining why our requirements files are so wordy, and make them wordier, to include links to code, documentation, and changes for our third-party libraries.
* django-tidings 1.1 → 2.0: Support Django 1.9 to 2.0, Celery 4.x, non-pickle serializer.
escattone
approved these changes
Feb 12, 2018
Contributor
escattone
left a comment
There was a problem hiding this comment.
Nice work on updating django-tidings as well as this work, thanks @jwhitlock!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this locally by adding a watch and unsubscribing, but didn't send a watch email, which requires a second user. I think this can wait for staging, where I'm subscribed to Ryan's test page.