This repository was archived by the owner on Aug 26, 2022. It is now read-only.
fix bug 1419466 - added jinja2 extension of translating the 404 page #4655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitlock
reviewed
Feb 7, 2018
Contributor
jwhitlock
left a comment
There was a problem hiding this comment.
Thanks @hritvi! This is correct for the 404 page. Do you want to make a similar change for the 500 page?
https://github.com/hritvi/kuma/blob/3daffb2ff45aef851cfbfc3c8b7d49980aa149b3/jinja2/500.html#L16
jwhitlock
approved these changes
Feb 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #4655 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 260 260
Lines 23534 23534
Branches 1688 1688
=======================================
Hits 22434 22434
Misses 888 888
Partials 212 212Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the extension of jinja2 for translating the "Not Found" in the jinja2/404.html file and in the jinja2/500.html page