Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Conversation

@bookshelfdave
Copy link
Contributor

following the docs here, the MySQL database should now be populated with sample data upon demo instance creation.

Note: demo branch names must follow Deis naming conventions, hence the sad branch name so I could test an actual demo instance.

@codecov-io
Copy link

Codecov Report

Merging #4153 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4153   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files         146      146           
  Lines        8967     8967           
  Branches     1198     1198           
=======================================
  Hits         7717     7717           
  Misses       1009     1009           
  Partials      241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a30e72...0098df3. Read the comment docs.

@jgmize
Copy link
Contributor

jgmize commented Mar 14, 2017

Copy link
Contributor

@jgmize jgmize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @metadave

@jgmize
Copy link
Contributor

jgmize commented Mar 14, 2017

This lgtm, but I'd like to give @escattone a chance to take a look before merging.

@jgmize
Copy link
Contributor

jgmize commented Mar 14, 2017

@escattone gave 👍 via vidyo, merging.

@jgmize jgmize merged commit 8b05e38 into master Mar 14, 2017
@jgmize jgmize deleted the dynamicmysql branch March 14, 2017 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants