Demo deploys to k8s via Jenkinsfile + Deis workflow #4121
Conversation
|
Working with @metadave and @escattone on this, still some items to address |
| // DEIS_PROFILE=virginia deis2 config:push -p .env-dist -a mdn-demo | ||
| // Creating config... ...o..Error: Unknown Error (409): {"detail":"jenkins changed nothing - release stopped"} | ||
| // make: *** [deis-config] Error 1 | ||
| sh "KUBECONFIG=${env.KUBECONFIG} kubectl --namespace=${env.DEIS_APP} apply -f k8s/" |
There was a problem hiding this comment.
I could see this being a helm chart down the road, but great for now.
Codecov Report@@ Coverage Diff @@
## master #4121 +/- ##
=======================================
Coverage 86.21% 86.21%
=======================================
Files 144 144
Lines 8877 8877
Branches 1187 1187
=======================================
Hits 7653 7653
+ Misses 990 988 -2
- Partials 234 236 +2
Continue to review full report at Codecov.
|
aecadb7 to
9a1eac6
Compare
Makefile
Outdated
| requirements = -r requirements/local.txt | ||
| # set Django settings module if not already set as env var | ||
| export DJANGO_SETTINGS_MODULE ?= kuma.settings.testing | ||
| export DJANGO_SETTINGS_MODULE ?= kuma.settings.prod |
There was a problem hiding this comment.
I think it's safest for the default value of the DJANGO_SETTINGS_MODULE to remain at kuma.settings.testing for now, since this Makefile is used in multiple contexts that we'll need to sort out (like tox.ini which is used by Travis via .travis.yml). Instead, can we find another way to set DJANGO_SETTINGS_MODULE=kuma.settings.prod before the make build-static in the Dockerfile?
768a0af to
097b63d
Compare
|
It seems that this commit addresses my concern of not (yet) messing with the The goal is to avoid (for now) addressing the consequences in other contexts that we'll need to sort out (like tox.ini which is used by Travis via .travis.yml). I'd love to have @jwhitlock take a look at this as well to get his thoughts before I merge. |
|
Actually, I had an idea overnight that would be better, let me try that before any further review. |
50bbe9c to
3b890c7
Compare
|
My idea didn't work, as it was based on the Dockerfile picking up the DJANGO_SETTINGS_MODULE setting from its environment (in this case, the demo.groovy file), which it doesn't. Never mind. This is good to go. |
WIP working example: https://mdn-demo.virginia.moz.works/en-US/ deployed by https://ci.us-west.moz.works/view/MDN/job/mdn_multibranch_pipeline/job/demo/16/console