This repository was archived by the owner on Jul 31, 2024. It is now read-only.
Switch to pip-compile#1427
Merged
jwhitlock merged 4 commits intomozilla:mainfrom Nov 30, 2020
jwhitlock:switch-to-pip-compile-1407
Merged
Switch to pip-compile#1427jwhitlock merged 4 commits intomozilla:mainfrom jwhitlock:switch-to-pip-compile-1407
jwhitlock merged 4 commits intomozilla:mainfrom
jwhitlock:switch-to-pip-compile-1407
Conversation
Ichnaea is no longer built as a package as part of test or deployment.
pip-compile, from pip-tools, takes a .in file, adds the hashes and the requirements-of-requirements, and outputs a requirements.txt file.
Change the command to `make update-reqs`, and rename the Docker shell script to match other scripts. Remove the --verify option and related CI build step, since it will fail when a requirement-of-a-requirement is updated. Convert the document to RST and include in the documentation.
jwhitlock
commented
Nov 30, 2020
Contributor
Author
jwhitlock
left a comment
There was a problem hiding this comment.
Works locally and in CI. I used pip freeze to compare the installed requirements before and after. To keep requirements from changing, I added the section #TODO: Unpin these with the December update.
I'm merging now, so I can see how Dependabot works with this workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip-compile, part of pip-tools, provides a new process for maintaining Python dependencies. The top-level dependencies are defined in arequirements.infile, andpip-compilewill determine the dependencies-of-dependencies and calculate hashes, writing them torequirements.txt.This places the dependencies in four files,
shared.in,docs.in,prod.in, anddev.in. After runningmake update-reqs, these generatedocs.txt(for ReadTheDocs) anddev.txt(for the Docker image).Other changes:
requirementsfolder.setup.py, which we haven't used in a while.Update 1: Changed from
make reqs-regentomake update-requirements, removed CI check, added new docs page.Update 2:
make update-reqsis shorter, doesn't break formatting ofmake help. Also, added in--use-feature=2020-resolver, so now this fixes the issue.Fixes #1407