Bug 1997963 - Config performance optimizations for glean-gradle-plugin #3326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahochheiden
commented
Nov 15, 2025
- Lazy task registration: Changed project.task() to project.tasks.register() to defer task configuration until needed
- Deferred disk I/O: Replaced configuration-time file existence checks with execution-time checks using onlyIf and .filter { it.exists() }
- Optional inputs: Used inputs.files().optional(true) instead of conditionally adding inputs based on file existence
- Configuration avoidance: Replaced .all() with .configureEach() for variant iteration
- Lazy task dependencies: Used taskProvider.configure { dependsOn() } to defer dependency setup
6fa8b94 to
af50679
Compare
ncalexan
approved these changes
Nov 17, 2025
Member
ncalexan
left a comment
There was a problem hiding this comment.
Everything here looks sensible. Assuming that the onlyIf stanzas are configuration-cache compatible, roll on!
The thing that I can't verify (without significant effort) is that the configuration-time IO is appropriate, i.e., that we don't process any metrics/pings YAML until execution-time. But that can be observed later, if it shows up as we profile more of the Fenix build.
Member
|
I re-kicked the CI. Seems that was an intermittent. Not sure why it happened on both Android runs on different platforms |
…gradle-plugin
- Lazy task registration: Changed project.task() to project.tasks.register() to defer task configuration until needed
- Deferred disk I/O: Replaced configuration-time file existence checks with execution-time checks using onlyIf and .filter { it.exists() }
- Optional inputs: Used inputs.files().optional(true) instead of conditionally adding inputs based on file existence
- Configuration avoidance: Replaced .all() with .configureEach() for variant iteration
- Lazy task dependencies: Used taskProvider.configure { dependsOn() } to defer dependency setup
af50679 to
faab52d
Compare
badboy
approved these changes
Nov 19, 2025
Member
badboy
left a comment
There was a problem hiding this comment.
If it gets the job done, I'm happy! :)
Member
Author
|
Thanks! I did have one revision I wanted to make suggested by Nick. I'll open another pull request for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.