This repository was archived by the owner on Apr 3, 2019. It is now read-only.
feat(emails): Throw unique error if initiating password reset from secondary email #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from secondary email
vladikoff
reviewed
May 1, 2017
lib/routes/password.js
Outdated
| // If no secondary email exists, we want to throw the original account unknown | ||
| // error because the user could potentially create this account. | ||
| if (emailErr.errno === error.ERRNO.SECONDARY_EMAIL_UNKNOWN) { | ||
| return err |
Contributor
There was a problem hiding this comment.
should this be throw? contradicts the doc above we want to throw the original account unknown error
Contributor
Author
There was a problem hiding this comment.
Good catch @vladikoff, added a test case to cover this case. Opted to put it in the recovery emails section because it only gets triggered when secondary emails are enabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes mozilla/fxa-content-server#4996 (comment) by sending a unique error if a user is attempting to reset an account from a secondary email. This will cause the content server not to show the option of creating that account.
@vladikoff r?