-
Notifications
You must be signed in to change notification settings - Fork 227
Closed
Labels
Description
The OAuth server exposes some API endpoints under /client-tokens that can be used for listing and deleting the OAuth clients attached to a user's account. We used to use these as part of the devices-and-apps list, but that has since switched over to using the new /attached_clients endpoint. Ripgrepping the code and inspecting request logs in bigquery, I don't think anything is using the /client-tokens endpoints any more.
We should remove them, which AFAICT would include:
- Deleting the
fetchOAuthAppsanddeleteOAuthAppmethods on the content-server'soauth-client.js. - Removing the code for these routes in auth-server's
./lib/oauth/routes/client-tokensand the plumbing that hooks them up. - Removing the
getActiveClientsByUidmethod from the auth-server's OAuth DB object, since it is only used by these routes. - Removing auth-server's
lib/oauth/db/helpers.jssince it only contains a single function and that function is only used bygetActiveClientsByUidabove. - Removing the
idproperty from auth-server'slib/oauth/db/accessToken.js, since it only exists so these objects can be passed to the helper above.
Not a bad potential cleanup overall!
┆Issue is synchronized with this Jira Task
┆Issue Number: FXA-1286
Reactions are currently unavailable