Add Windows support #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're mostly in order, but not entirely. This is important because we later do binary search on them!
The commit also removes the JSON test, because JSON escaping is now done with the Windows test due to the use of backslashes in Windows path names. And it adds some documentation about how the test inputs were created, because it's not obvious and worth recording. Fixes #4.
gabrielesvelto
approved these changes
Nov 26, 2019
Collaborator
gabrielesvelto
left a comment
There was a problem hiding this comment.
LGTM with just a few nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
r? @gabrielesvelto