Bugs 1120827, 1120831: Improve accessibility#77
Merged
thebnich merged 2 commits intomozilla-mobile:masterfrom Jan 21, 2015
Merged
Bugs 1120827, 1120831: Improve accessibility#77thebnich merged 2 commits intomozilla-mobile:masterfrom
thebnich merged 2 commits intomozilla-mobile:masterfrom
Conversation
Contributor
|
Thanks for the PR! Can you please file a bug, then update the title of this PR to reference that bug #? You can use the other open PRs as a reference if helpful. |
Contributor
Author
|
Thanks for the quick turnaround. I did:
Please let me know if there is anything else to make a contribution properly, it's my first time contributing to Mozilla. :-) |
Contributor
Author
|
I made some updates:
|
Contributor
|
Thanks for the contribution! Unfortunately, it looks like this got bitrotted by #100. Would you mind rebasing this PR so we can merge it? |
Add accessibility labels to elements that use visual cues to fully or partially communicate their functions: - back and forward button - show tabs button - secure connection - reader - address and search text field - search engine in search suggestion - avatar
This allows for better VoiceOver user experience as the user does not have to go to the cancel button in tab bar or to the back button in toolbar to invoke them and instead can use the scrub gesture from anywhere.
Contributor
Author
Done. |
Contributor
|
Looks great, thanks! |
thebnich
added a commit
that referenced
this pull request
Jan 21, 2015
Bugs 1120827, 1120831: Improve accessibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add accessibility labels etc. for buttons and other elements whose function is conveyed mostly visually. Also provide VoiceOver scrub gesture where convenient.
Submitted under MPL v2.0 by my employer, A11Y LTD.