Bug-1958596 add dark_theme to theme guide#2050
Merged
rebloor merged 2 commits intoApr 17, 2025
Merged
Conversation
This was referenced Apr 15, 2025
emilio
reviewed
Apr 15, 2025
emilio
reviewed
Apr 16, 2025
| }, | ||
| "colors": { | ||
| "frame": "#000000", | ||
| "tab_background_text": "#FFF" |
There was a problem hiding this comment.
I'd use 3 or 6 digit hex codes consistently, but that's pre-existing too...
emilio
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds information about the
dark_thememanifest key. introduced in Firefox 68 (Bug 1525762), in response to comment on Comment 15 on Bug 1958596.Related issues
dark_thememanifest key documentation mdn/content#39122dark_thememanifest key support mdn/browser-compat-data#26511