cython: Add options for specifying header and imports#619
Merged
emilio merged 1 commit intomozilla:masterfrom Nov 25, 2020
Merged
cython: Add options for specifying header and imports#619emilio merged 1 commit intomozilla:masterfrom
emilio merged 1 commit intomozilla:masterfrom
Conversation
This was referenced Nov 17, 2020
emilio
approved these changes
Nov 25, 2020
| # `from module cimport name1, name2` declarations added in the same place | ||
| # where you'd get includes in C. | ||
| [cython.cimports] | ||
| module = ["name1", "name2"] |
Collaborator
There was a problem hiding this comment.
This looks fine though I think this could pretty much use after_includes.
Contributor
Author
There was a problem hiding this comment.
If imports are added to after_includes, then you'd either have two separate configs for C and Cython (which is not desirable), or use
#if 0
from module cimport name1, name2
#endif
emitted into both .h and .pxd (which is not pretty).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C header
.hand Cython.pxdare generated as a pair, so it's important to be able to generate them from a single config file.Two new options in this PR allow to do it without hacks.
One option allows to "link" the
.pxdto.h, and another one allows to add some imports.(I don't plan to add any more Cython-specific options in the near future, these two are the ones with highest return-on-investment.)